Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update byte stream spec #351

Closed
wants to merge 19 commits into from
Closed

Update byte stream spec #351

wants to merge 19 commits into from

Conversation

tyoshino
Copy link
Member

@tyoshino tyoshino commented May 1, 2015

@tyoshino
Cleanup BinaryExtension.md for async read() model
8cf9d9c
@tyoshino
Adding some algorithm to BinaryExtension.md
3174568
@tyoshino
Make read(view) return immediately after consuming queue
bf1bb29 
Suggested at #177 (comment)
@tyoshino
Add detaching step to ByobByteStreamReader.read(view)
a2fc88e
@tyoshino
Defined behavior of each method on ByobByteStreamReader without detai…
5056a21 
…led algorithm
@tyoshino
More text about behavior of the BYOB reader's releaseLock()
374ac78 
Suggested by Yutaka at 5056a21#commitcomment-10384245
@tyoshino
State that cancel() makes the byte stream closed
809afb7 
Suggested by Yutaka at 5056a21#commitcomment-10384305
@tyoshino
Use "uncleanly" than "unsuccessful" for BYOB reader's cancel() to emp…
3102eff 
…hasize that cancellation does happen

Suggested by Yutaka at 5056a21#commitcomment-10384336
@tyoshino
Bind the fulfillment value to fulfillmentValue in the explainer of th…
09698a4 
…e BYOB reader's read(view)

Addresses 5056a21#commitcomment-10384387
@tyoshino
Update algorithm section of the BYOB reader's read(view)
951c41b 
Addresses
5056a21#commitcomment-10384566
5056a21#commitcomment-10384559
@tyoshino
Explain the state of ByobByteStreamReader
c4a404e
@tyoshino
Reduce the level of headlngs in BinaryExtension.md
ddcf592
@tyoshino
Add a link to #294 in BinaryExtension.md
c328894
@tyoshino
BinaryExtension.md: Put return value explanations into level 6 headings
0783919
@tyoshino
BinaryExtension.md: Add "semantics" section to get closed()
fd5389c
@tyoshino
BinaryExtension.md: Add ReadableByteStreamReader
5521c85
@tyoshino
Use explicit algorithm to define publicly visible behavior
1a49b5e 
As discussed at #312
@tyoshino
Removed sections that have been sublimed into PR #343
17a7f60
@tyoshino
Move explainer texts to docs/Explainer.md
ac229f1 
Created docs/ directory as suggested at:
#300 (comment)

Added WARNING texts to unstable APIs (BYOB reader)
@tyoshino tyoshino mentioned this pull request May 1, 2015
Open
21 tasks
@domenic domenic mentioned this pull request May 1, 2015
Closed
@domenic
Copy link
Member

domenic commented May 3, 2015

Merged as 5b47faa per plan at #343 (comment).

@domenic domenic closed this May 3, 2015
@tyoshino tyoshino deleted the asyncbytestream branch May 7, 2015 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tyoshino @domenic @yutakahirano