Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge getBYOBReader() into getReader() and rename class names and switches #436

Merged
merged 3 commits into from Apr 8, 2016
Merged

Merge getBYOBReader() into getReader() and rename class names and switches #436

merged 3 commits into from Apr 8, 2016

Conversation

tyoshino
Copy link
Member

@tyoshino tyoshino commented Apr 6, 2016

Fixes #294

@tyoshino tyoshino mentioned this pull request Apr 8, 2016
Closed
@tyoshino @domenic
Change how you construct a readable byte stream
3a6caaa 
Instead of `byob: true`, it's now `type: "bytes"`. Partially fixes #294.
@domenic
Copy link
Member

domenic commented Apr 8, 2016

Thanks! I force-pushed some fixups and will merge. I should have had them as separate commits so you can review; sorry :(. The main changes were:

  • Revert rs-byob-request -> rbs-request ID changes
  • Add a few tests (under web-platform tests)
  • Tidy up non-normative notes around readers
  • Fix up how type is stringified and such in the constructor

@domenic domenic merged commit 3a6caaa into master Apr 8, 2016
@domenic domenic deleted the removeGetBYOBReader branch April 8, 2016 20:38
@tyoshino
Copy link
Member Author

Thanks

Revert rs-byob-request -> rbs-request ID changes

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@domenic domenic

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tyoshino @domenic