Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contributing.md with various editing guidelines #439

Merged
merged 1 commit into from Apr 21, 2016
Merged

Conversation

domenic
Copy link
Member

@domenic domenic commented Apr 18, 2016

Closes #437; closes #421.

@tyoshino can you think of other things we should include?


Wrap lines to 120 columns. (This is not yet consistently followed.)

Use two-spec indents.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two space?

@tyoshino
Copy link
Member

lgtm!

@domenic domenic merged commit 007150f into master Apr 21, 2016
@domenic domenic deleted the contributing branch April 21, 2016 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Guideline] Where to factor out logic [Guideline] Style
2 participants