Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ReadableStream spec inconsistencies #521

Closed
wants to merge 3 commits into from
Closed

fix ReadableStream spec inconsistencies #521

wants to merge 3 commits into from

Conversation

isonmad
Copy link
Contributor

@isonmad isonmad commented Sep 22, 2016

Erred on the side of adding asserts rather than removing them.

isonmad added 3 commits September 22, 2016 02:23
fix typo in WritableStreamDefaultWriterClose
db5f652
add asserts to ReadableStreamDefaultController
766b199 
These asserts are in ReadableByteStreamController,
and there doesn't seem to be a reason they wouldn't
be here too.
replace assignment with assert in ReadableByteStreamControllerCallPul…
33bf50a 
…lIfNeeded

There should be no possible way for _pullAgain to have become true
without _pulling becoming true first.
@domenic
Copy link
Member

domenic commented Sep 25, 2016

Thank you so much! Merged as 3fd1246, 4be6fd1, and 7ba2589. What name can we list you under in the Acknowledgments? Is "isonmad" preferred?

@domenic domenic closed this Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@isonmad @domenic