Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check precisely the way that transformer.transform() is called #689

Closed
wants to merge 3 commits into from
Closed

Check precisely the way that transformer.transform() is called #689

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bb03d6
Check precisely the way that transformer.transform() is called
ricea Mar 8, 2017
3de0f57
Clarify the test for the bad optimisation
ricea Mar 9, 2017
31569b7
Fix errors in last commit
ricea Mar 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions reference-implementation/to-upstream-wpts/transform-streams/general.js
View file
Open in desktop
Expand Up @@ -316,7 +316,7 @@ promise_test(t => {
// return TransformStreamDefaultTransform(chunk, controller);

const transformer = {
transform(chunk, controller) {
transform() {
transformer.transform = undefined;
throw thrownError;
}
Expand Down Expand Up @@ -360,7 +360,7 @@ promise_test(() => {
});
const writer = ts.writable.getWriter();
writer.write('a');
writer.write('b)');
writer.write('b');
writer.close();
return readableStreamToArray(ts.readable)
.then(chunks => {
Expand Down