Use ResetQueue in WritableStreamDefaultControllerProcessWrite #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WritableStreamDefaultControllerProcessWrite contained the line "If wasErrored is false, set controller.[[queue]] to an empty List." Generally it is better to use ResetQueue() to keep the [[queue]] and [[queueTotalSize]] slots in sink. Do that instead.
|
I'm only 90% sure this is right, so please review carefully. |
domenic
added a commit
that referenced
this pull request
Mar 27, 2017
The main motivation for this change is to centralize the erroring of a writable stream into a single abstract operation, WritableStreamError(), which takes care of all the relevant operations together, instead of sprinkling them through separate state transitions. This closes #704 by subsuming it; now ResetQueue() is always called when erroring the stream, no matter the code path. The effort to do this revealed a semantic mismatch wherein we deciding abort()ing during an in-flight close should error the stream, but the abort should suceed. This was not a good decision, in retrospect; it makes this particular instance of erroring the stream very unusual. And we recognized that it was weird, because we made abort() return a fulfilled promise. Instead we should treat this as a success and close the stream, reflected in both the return value of abort() and in the stream's state. This also introduces internal methods to writable stream controllers, paralleling the structure already in place for readable stream controllers. These methods were already there, disguised as abstract operations; since this change introduces a third such hook, it was time to properly pull them out as internal methods.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WritableStreamDefaultControllerProcessWrite contained the line "If wasErrored is
false, set controller.[[queue]] to an empty List."
Generally it is better to use ResetQueue() to keep the [[queue]] and
[[queueTotalSize]] slots in sink. Do that instead.