Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require pipeTo() to properly use the destination queue #720

Merged
merged 5 commits into from Mar 31, 2017
Merged

Require pipeTo() to properly use the destination queue #720

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46892c1
Require pipeTo() to properly use the destination queue
domenic Mar 30, 2017
5c9bfcc
"promptly"
domenic Mar 30, 2017
fb4c8b8
Remove the heuristic allowance for determining flow rate
domenic Mar 30, 2017
49e3b1c
Make clearer; fix wrapping
domenic Mar 31, 2017
a4e9463
Roll tests
domenic Mar 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.bs
View file
Open in desktop
Expand Up @@ -645,8 +645,8 @@ ReadableStream(<var>underlyingSource</var> = {}, { <var>size</var>, <var>highWat
determine the size of the chunks read from _reader_. Otherwise, the desired size may be used to determine the
flow rate heuristically, e.g. by delaying reads while the desired size is judged to be "low" compared to the
size of <a>chunks</a> that have been typically read.
* After taking into account these backpressure signals, reading and writing should be done as fast as possible;
other signals should not be used to delay the continual reading/writing.
* After taking into account these backpressure signals, reading and writing should be done promptly; other
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably say less here now that we don't have to argue with the previous sentence. How about:

"Reads or writes should not be delayed for reasons other than backpressure."

signals should not be used to delay the continual reading/writing.
<p class="example" id="example-bad-backpressure">An implementation that waits for each write to successfully complete before proceeding to
the next read/write operation violates this recommendation. In doing so, such an implementation makes the
<a>internal queue</a> of _dest_ useless, as it ensures _dest_ always contains at most one queued
Expand Down