Rename "transformStream" variables to "stream" #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricea
force-pushed
the
transform-stream-rename-stream-variable
branch
from
548b405
to
22a966e
Compare
|
Hmm maybe also "transformStreamController" -> controller when used as a variable. |
For consistency with Readable- and WritableStream, and brevity, rename all "transformStream" parameters and local variables to just "stream". Rename _transformStream members in Source and Sink to _ownerTransformStream which is hopefully slightly clearer. No functional changes.
ricea
force-pushed
the
transform-stream-rename-stream-variable
branch
from
22a966e
to
f706787
Compare
TransformStreamDefaultTransform took a parameter named transformStreamController. Rename it to "controller" for consistency with the rest of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with Readable- and WritableStream, and brevity, rename
all "transformStream" parameters and local variables to just "stream".
Rename _transformStream members in Source and Sink to
_ownerTransformStream which is hopefully slightly clearer.
No functional changes.