Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extension point for byte transform streams #820

Merged
merged 2 commits into from Oct 6, 2017

Conversation

ricea
Copy link
Collaborator

@ricea ricea commented Oct 2, 2017

Prohibit non-undefined values of readableType and writableType properties
on the transformer to reserve them for future use defining byte
transforms.

@domenic
Copy link
Member

domenic commented Oct 2, 2017

Maybe do type too in case we end up wanting to just control both at once?

@ricea
Copy link
Collaborator Author

ricea commented Oct 3, 2017

I think having type alongside readableType and writableType would be confusing. Asymmetrical transform streams appear to be useful, with TextEncoder being the canonical example. In which case, we need readableType: 'bytes' which would mean not having type. We need more experience with byte streams before we can be certain.

Since we don't know what is needed yet, maybe we should just leave no extension points at all? Or maybe I'm misunderstanding?

Prohibit non-undefined values of readableType and writableType properties
on the transformer to reserve them for future use defining byte
transforms.
@ricea ricea force-pushed the transform-stream-byte-extension-point branch from 40c485b to 33702b4 Compare October 6, 2017 12:01
@domenic
Copy link
Member

domenic commented Oct 6, 2017

I guess it slipped my mind that asymmetrical transform streams were obviously necessary. I was envisioning a potential future where everything was symmetrical, but that's not realistic. So indeed this seems like the way to go.

@domenic domenic merged commit f9765ee into whatwg:master Oct 6, 2017
@ricea ricea deleted the transform-stream-byte-extension-point branch October 11, 2017 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants