Remove inaccurate note about ReadableStreamDefaultControllerEnqueue #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReadableStreamDefaultControllerEnqueue has a note indicating that it could be called when the stream was closed without an exception being thrown. This hasn't been true since December 2015. Remove the inaccurate note. Fixes whatwg#824.
|
I think we should move the first half of this note to ReadableStreamDefaultControllerCanCloseOrEnqueue, as it remains a tricky situation. Something like
|
ricea
added
the
editorial
Clarify the cases when [[closeRequested]] is false but state is not "readable".
|
I tried to also cover the errored case in the note. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadableStreamDefaultControllerEnqueue has a note indicating that it
could be called when the stream was closed without an exception being
thrown. This hasn't been true since December 2015. Remove the inaccurate
note.
Fixes #824.