Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TransformStreamDefaultControllerTerminate down #835

Merged
merged 1 commit into from Oct 11, 2017

Conversation

ricea
Copy link
Collaborator

@ricea ricea commented Oct 10, 2017

Return TransformStreamDefaultController abstract ops to alphabetical
order by moving Terminate down. Also put the terminate() method in
last-place in the class definition to improve alphabetisation and make it
clear that it is less important.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebase.

Return TransformStreamDefaultController abstract ops to alphabetical
order by moving Terminate down. Also put the terminate() method in
last-place in the class definition to improve alphabetisation and make it
clear that it is less important.
@ricea ricea force-pushed the transform-stream-move-terminate branch from c23d514 to fe4ddc0 Compare October 11, 2017 07:08
@ricea ricea merged commit c410430 into whatwg:master Oct 11, 2017
@ricea ricea deleted the transform-stream-move-terminate branch October 11, 2017 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants