Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw when calling RS's controller.error() #895

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Do not throw when calling RS's controller.error() #895

merged 2 commits into from
Mar 8, 2018

Commits on Mar 7, 2018

  1. Do not throw when calling RS's controller.error() 

    Previously, we would throw an exception when calling controller.error() for a readable stream that was not readable. As noted in #821, this is inconsistent with the behavior introduced for writable and transform streams. The fact that the spec is constantly checking whether it's in the right state, e.g. via ReadableStreamDefaultControllerCallPullIfNeeded, is also a strong indicator that we should not throw.

This simplifies various abstract operations by centralizing state checks and removing ReadableStreamDefaultControllerCallPullIfNeeded.

Closes #821.
    @domenic
    domenic committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    df0f087 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2018

  1. Roll WPT

    @domenic
    domenic committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    2824abc View commit details
    Browse the repository at this point in the history