Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WritableStream: clear algorithms once they will no longer be called #940

Merged
merged 4 commits into from
Jul 13, 2018

Commits on Jul 12, 2018

  1. WritableStream: clear algorithms once they will no longer be called

    Clear the [[writeAlgorithm]], [[closeAlgorithm]] and [[abortAlgorithm]]
    slots when they will no longer be called. This allows resources such as
    the underlying sink object to be freed.
    
    Add [[FinishSteps]] polymorphic operation so that the algorithms will be
    cleared correctly even for a future controller that has different slots.
    [[FinishSteps]] is only used when the clear operation is initiated from
    the WritableStream -- in the case of abort() and close() the clear
    operation is initiated by the controller itself and doesn't indirect via
    [[FinishSteps]].
    
    Part of whatwg#932.
    ricea committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    a129479 View commit details
    Browse the repository at this point in the history
  2. Perform all the algo resets from inside the controller code

    Avoid having polymorphic calls by triggering algo resets from the
    controller code. This can lead to redundant calls to ClearAlgorithms,
    but they are harmless.
    ricea committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    c8fee18 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    598403a View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. Wrap long line

    ricea committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    6f1ac85 View commit details
    Browse the repository at this point in the history