Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadableStream: clear algorithms once they will no longer be used #944

Merged
merged 1 commit into from Jul 31, 2018
Merged

ReadableStream: clear algorithms once they will no longer be used #944

merged 1 commit into from Jul 31, 2018

Conversation

ricea
Copy link
Collaborator

@ricea ricea commented Jul 23, 2018 •
edited by pr-preview bot

Clear the [[pullAlgorithm]] and [[cancelAlgorithm]] slots when they will
no longer be called. This allows resources such as the underlying source
to be freed.

Preview | Diff

@ricea
ReadableStream: clear algorithms once they will no longer be used
9f68947 
Clear the [[pullAlgorithm]] and [[cancelAlgorithm]] slots when they will
no longer be called. This allows resources such as the underlying source
to be freed.
domenic
domenic approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It occurs we may need to similar things for sizeAlgorithm?

@ricea
Copy link
Collaborator Author

ricea commented Jul 31, 2018

I missed sizeAlgorithm. Fortunately I think it's trivial. I will do it in a separate PR for readable and writable at the same time.

@ricea ricea merged commit 9098b5d into whatwg:master Jul 31, 2018
@ricea ricea deleted the readable-clear-algos branch July 31, 2018 05:31
@ricea ricea mentioned this pull request Jul 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ricea @domenic