-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: update copyright license and Bikeshed boilerplate #360
Conversation
See https://blog.whatwg.org/copyright-license-change for the former and whatwg/meta#23 plus speced/bikeshed#1155 for the latter. The new boilerplate includes the new copyright license, so this commit just removes it from the source file, as it does many other things that are now deduplicated into the Bikeshed boilerplate.
Hmm, this doesn't update the LICENSE file. "do not merge yet" until both the Bikeshed change gets merged and I fix that. |
Blocked on whatwg/sg#51 |
url.bs
Outdated
!Commits: <a href="https://twitter.com/urlstandard">@urlstandard</a> | ||
!Tests: <a href=https://github.com/w3c/web-platform-tests/tree/master/url>web-platform-tests url/</a> (<a href=https://github.com/w3c/web-platform-tests/labels/url>ongoing work</a>) | ||
!Translation (non-normative): <span title=Japanese><a href=https://triple-underscore.github.io/URL-ja.html lang=ja hreflang=ja rel=alternate>日本語</a></span> | ||
Translation: ja https://triple-underscore.github.io/URL-ja.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this does not generate the desired markup. That's why I use !Translation (non-normative)
throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out the result; it seemed identical to me. But we can also fix Bikeshed while we're working on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should at least change the message to just say "non-normative". "Likely out-of-date" is not friendly to the translators. Is the generated output available somewhere? https://whatpr.org/url/360.html has a very different heading, though I suspect that's due to a Bikeshed mismatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In speced/bikeshed#1155 I changed it to "potentially". Is that good or do you prefer just removing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer just removing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll update the Bikeshed PR; hopefully @tabatkins will be OK with it since I think it's mostly (all?) WHATWG specs that use this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm fine with adjusting the language to whatever y'all want.
And @annevk, if I've written a feature specifically for you and it doesn't meet your needs any more, please let me know so I can fix it rather than just ignoring the feature and working around it manually. ^_^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I was waiting on speced/bikeshed#1058 to be fixed, but then forgot about it or maybe I was waiting for us to use our own templating since it didn't quite work out, even if that were fixed.
See also whatwg/meta#56 btw. |
Here is the output: <dt>Translations <small>(non-normative and potentially out-of-date)</small>:</dt>
<dd><span title="Japanese"><a href="https://triple-underscore.github.io/URL-ja.html" hreflang="ja" rel="alternate" lang="ja">日本語</a></span></dd> |
This change looks reasonable. Can we generate an example copy to preview the standard with the Bikeshed changes? Would be nice to see what changed and how. |
url.bs
Outdated
@@ -3,7 +3,7 @@ Group: WHATWG | |||
H1: URL | |||
Shortname: url | |||
Text Macro: TWITTER urlstandard | |||
Abstract: The URL Standard defines URLs, domains, IP addresses, the <code title>application/x-www-form-urlencoded</code> format, and their API. | |||
Abstract: The URL Standard defines URLs, domains, IP addresses, the <code><a>application/x-www-form-urlencoded</a></code> format, and their API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want links in abstracts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? I assume that's what the title
was supposed to be about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The empty title was there to prevent a link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that abstracts stand on their own. If you need to click on links it has kinda failed. Perhaps that means this abstract is not super great though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to remove it, but I think links in abstracts are nice, just like they are anywhere else.
This one got missed in foolip's pass, I guess
See https://blog.whatwg.org/copyright-license-change for the former and
whatwg/meta#23 plus
speced/bikeshed#1155 for the latter. The new
boilerplate includes the new copyright license, so this commit just
removes it from the source file, as it does many other things that are
now deduplicated into the Bikeshed boilerplate.
Preview | Diff