Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: update copyright license and Bikeshed boilerplate #360

Merged
merged 8 commits into from
Jan 5, 2018

Conversation

domenic
Copy link
Member

@domenic domenic commented Dec 18, 2017

See https://blog.whatwg.org/copyright-license-change for the former and
whatwg/meta#23 plus
speced/bikeshed#1155 for the latter. The new
boilerplate includes the new copyright license, so this commit just
removes it from the source file, as it does many other things that are
now deduplicated into the Bikeshed boilerplate.


Preview | Diff

See https://blog.whatwg.org/copyright-license-change for the former and
whatwg/meta#23 plus
speced/bikeshed#1155 for the latter. The new
boilerplate includes the new copyright license, so this commit just
removes it from the source file, as it does many other things that are
now deduplicated into the Bikeshed boilerplate.
@domenic
Copy link
Member Author

domenic commented Dec 18, 2017

Hmm, this doesn't update the LICENSE file. "do not merge yet" until both the Bikeshed change gets merged and I fix that.

@domenic domenic added the do not merge yet Pull request must not be merged per rationale in comment label Dec 18, 2017
@domenic
Copy link
Member Author

domenic commented Dec 18, 2017

Blocked on whatwg/sg#51

url.bs Outdated
!Commits: <a href="https://twitter.com/urlstandard">@urlstandard</a>
!Tests: <a href=https://github.com/w3c/web-platform-tests/tree/master/url>web-platform-tests url/</a> (<a href=https://github.com/w3c/web-platform-tests/labels/url>ongoing work</a>)
!Translation (non-normative): <span title=Japanese><a href=https://triple-underscore.github.io/URL-ja.html lang=ja hreflang=ja rel=alternate>日本語</a></span>
Translation: ja https://triple-underscore.github.io/URL-ja.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this does not generate the desired markup. That's why I use !Translation (non-normative) throughout.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the result; it seemed identical to me. But we can also fix Bikeshed while we're working on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should at least change the message to just say "non-normative". "Likely out-of-date" is not friendly to the translators. Is the generated output available somewhere? https://whatpr.org/url/360.html has a very different heading, though I suspect that's due to a Bikeshed mismatch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In speced/bikeshed#1155 I changed it to "potentially". Is that good or do you prefer just removing it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer just removing it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll update the Bikeshed PR; hopefully @tabatkins will be OK with it since I think it's mostly (all?) WHATWG specs that use this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm fine with adjusting the language to whatever y'all want.

And @annevk, if I've written a feature specifically for you and it doesn't meet your needs any more, please let me know so I can fix it rather than just ignoring the feature and working around it manually. ^_^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was waiting on speced/bikeshed#1058 to be fixed, but then forgot about it or maybe I was waiting for us to use our own templating since it didn't quite work out, even if that were fixed.

@annevk
Copy link
Member

annevk commented Dec 19, 2017

See also whatwg/meta#56 btw.

@domenic
Copy link
Member Author

domenic commented Dec 19, 2017

Here is the output:

<dt>Translations <small>(non-normative and potentially out-of-date)</small>:</dt>
<dd><span title="Japanese"><a href="https://triple-underscore.github.io/URL-ja.html" hreflang="ja" rel="alternate" lang="ja">日本語</a></span></dd>

@annevk
Copy link
Member

annevk commented Jan 3, 2018

This change looks reasonable. Can we generate an example copy to preview the standard with the Bikeshed changes? Would be nice to see what changed and how.

@domenic
Copy link
Member Author

domenic commented Jan 3, 2018

url.bs Outdated
@@ -3,7 +3,7 @@ Group: WHATWG
H1: URL
Shortname: url
Text Macro: TWITTER urlstandard
Abstract: The URL Standard defines URLs, domains, IP addresses, the <code title>application/x-www-form-urlencoded</code> format, and their API.
Abstract: The URL Standard defines URLs, domains, IP addresses, the <code><a>application/x-www-form-urlencoded</a></code> format, and their API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want links in abstracts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? I assume that's what the title was supposed to be about.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty title was there to prevent a link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is that abstracts stand on their own. If you need to click on links it has kinda failed. Perhaps that means this abstract is not super great though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to remove it, but I think links in abstracts are nice, just like they are anywhere else.

This one got missed in foolip's pass, I guess
@domenic domenic merged commit e79b522 into master Jan 5, 2018
@domenic domenic deleted the new-whatwg-boilerplate branch January 5, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet Pull request must not be merged per rationale in comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants