Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: update copyright license and Bikeshed boilerplate #360

Merged
merged 8 commits into from
Jan 5, 2018
Merged

Meta: update copyright license and Bikeshed boilerplate #360

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c8257c2
Meta: update copyright license and Bikeshed boilerplate
domenic Dec 18, 2017
d9657c7
Replace LICENSE file
domenic Dec 19, 2017
fb619eb
Go for plaintext license file
domenic Dec 19, 2017
42cbf07
Add copyright statement at the top
domenic Dec 19, 2017
aa02116
Update copyright year
domenic Jan 2, 2018
00c806b
Fix some more linking errors
domenic Jan 4, 2018
492f328
No link after all
domenic Jan 5, 2018
a1e7f5a
Also update .travis.yml
domenic Jan 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions url.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Group: WHATWG
H1: URL
Shortname: url
Text Macro: TWITTER urlstandard
Abstract: The URL Standard defines URLs, domains, IP addresses, the <code title>application/x-www-form-urlencoded</code> format, and their API.
Abstract: The URL Standard defines URLs, domains, IP addresses, the <code><a>application/x-www-form-urlencoded</a></code> format, and their API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want links in abstracts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? I assume that's what the title was supposed to be about.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty title was there to prevent a link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is that abstracts stand on their own. If you need to click on links it has kinda failed. Perhaps that means this abstract is not super great though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to remove it, but I think links in abstracts are nice, just like they are anywhere else.

Translation: ja https://triple-underscore.github.io/URL-ja.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this does not generate the desired markup. That's why I use !Translation (non-normative) throughout.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the result; it seemed identical to me. But we can also fix Bikeshed while we're working on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should at least change the message to just say "non-normative". "Likely out-of-date" is not friendly to the translators. Is the generated output available somewhere? https://whatpr.org/url/360.html has a very different heading, though I suspect that's due to a Bikeshed mismatch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In speced/bikeshed#1155 I changed it to "potentially". Is that good or do you prefer just removing it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer just removing it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll update the Bikeshed PR; hopefully @tabatkins will be OK with it since I think it's mostly (all?) WHATWG specs that use this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm fine with adjusting the language to whatever y'all want.

And @annevk, if I've written a feature specifically for you and it doesn't meet your needs any more, please let me know so I can fix it rather than just ignoring the feature and working around it manually. ^_^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was waiting on speced/bikeshed#1058 to be fixed, but then forgot about it or maybe I was waiting for us to use our own templating since it didn't quite work out, even if that were fixed.

</pre>

Expand Down Expand Up @@ -2532,7 +2532,7 @@ name-value-type tuples. [[HTML]]
<p>The
<dfn id=concept-urlencoded-string-parser lt='urlencoded string parser'><code>application/x-www-form-urlencoded</code> string parser</dfn>
takes a string <var>input</var>, <a>UTF-8 encodes</a> it, and then returns the result of
<a><code>application/x-www-form-urlencoded</code> parsing</a> it.
<a lt="urlencoded parser"><code>application/x-www-form-urlencoded</code> parsing</a> it.



Expand Down