Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: use Infra substring operations #649

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Editorial: use Infra substring operations #649

merged 1 commit into from
Sep 13, 2021

Conversation

domenic
Copy link
Member

@domenic domenic commented Sep 9, 2021 •
edited by pr-preview bot

annevk
annevk approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we point out that technically code unit substring also works for all these cases? I guess nobody implements this as-is anyway so it's probably fine.

@domenic domenic merged commit 4edcc9f into main Sep 13, 2021
@domenic domenic deleted the infra-substring branch September 13, 2021 17:48
@domenic
Copy link
Member Author

domenic commented Sep 13, 2021

I think if I were to point that out I'd do it more generally, noting that past a certain point in the parser we're in the ASCII range and so code points vs. code units does not matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@domenic @annevk