Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add substrings to the end of the string #401

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Add substrings to the end of the string #401

merged 1 commit into from
Sep 10, 2021

Conversation

domenic
Copy link
Member

@domenic domenic commented Sep 9, 2021 •
edited by pr-preview bot
Loading

We have at least two consumers: whatwg/urlpattern#134 and various places in URL.

Preview | Diff

@domenic domenic mentioned this pull request Sep 9, 2021
Merged
annevk
annevk approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was initially thinking this should go below the examples, but looking at the text it seems reasonable.

@domenic domenic merged commit ff425b4 into main Sep 10, 2021
@domenic domenic deleted the substring-end-of-string branch September 10, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domenic @annevk