Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What should the property descriptor for @@unscopeable look like? #102

Closed
bzbarsky opened this issue Mar 25, 2016 · 4 comments · Fixed by #396
Closed

What should the property descriptor for @@unscopeable look like? #102

bzbarsky opened this issue Mar 25, 2016 · 4 comments · Fixed by #396
Labels
☕☕ difficulty:medium Hard to fix ⌛ duration:short Should be a short fix editorial Changes that do not affect how the standard is understood.

Comments

@bzbarsky
Copy link
Collaborator

Should it be enumerable? Writable? Configurable?

The spec currently just says:

then there MUST be a property on the interface prototype object whose name is the @@unscopeables symbol and whose value is an object created as follows

with nothing about the other parts of the property descriptor. I'm assuming this thing should be writable, configurable, and enumerable.
@domenic
Copy link
Member

domenic commented Mar 25, 2016

ES objects have writable: false, enumerable: false, configurable: true for this. I.e. the "you really shouldn't mess with this, but we won't prohibit you" propdesc.

@domenic
Copy link
Member

domenic commented Mar 25, 2016

And by ES objects I guess I just mean Array.prototype.

@bzbarsky
Copy link
Collaborator Author

Matching Array.prototype seems worthwhile.

@bzbarsky
Copy link
Collaborator Author

OK, what I'm going to implement in Firefox matches Array.prototype.

@tobie tobie added ⌛ duration:short Should be a short fix ☕☕ difficulty:medium Hard to fix editorial Changes that do not affect how the standard is understood. labels Jun 19, 2016
tobie added a commit to tobie/webidl that referenced this issue Jul 31, 2017
@tobie
Specify the property descriptor of @@unscopables.
7ac2724 
Fixes whatwg#102.
@tobie tobie mentioned this issue Jul 31, 2017
Merged
tobie added a commit that referenced this issue Aug 16, 2017
@tobie
Specify the property descriptor of @@unscopables. (#396)
48f1e62 
Fixes #102.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☕☕ difficulty:medium Hard to fix ⌛ duration:short Should be a short fix editorial Changes that do not affect how the standard is understood.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specify the property descriptor of @@unscopables. tobie/webidl
3 participants
@tobie @domenic @bzbarsky