Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define an operation to make a promise as handled #829

Closed
yutakahirano opened this issue Dec 13, 2019 · 2 comments · Fixed by #1090
Closed

Define an operation to make a promise as handled #829

yutakahirano opened this issue Dec 13, 2019 · 2 comments · Fixed by #1090

Comments

@yutakahirano
Copy link
Member

Split from whatwg/fetch#959.

Streams and Fetch sometimes manipulate promise.[[PromiseIsHandled]] to suppress unhandled rejection error reports. We'd appreciate if this is defined here so that they don't need to manipulate the internal property directly.

@annevk, @domenic, @ricea

@Ms2ger
Copy link
Member

Ms2ger commented Dec 16, 2019

Are all cases handling actual Promise objects, not IDL Promise<T>-typed values? Maybe it would make sense to add an abstract operation to ES directly.

@domenic
Copy link
Member

domenic commented Dec 16, 2019

They are actual Promise objects, but only because of the bad layering in Streams. After whatwg/streams#963 they should become Promise<T> objects. (And in the meantime, treating them as if they were such seems OK-ish.)

domenic added a commit that referenced this issue Jan 26, 2022
This helps specifications avoid reaching into internal slots. Closes #829.
domenic added a commit that referenced this issue Mar 7, 2022
This helps specifications avoid reaching into internal slots. Closes #829.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants