Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OptOutError to the error names list #1231

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

nickburris
Copy link
Contributor

@nickburris nickburris commented Nov 11, 2022

This PR adds a new OptOutError to the DOMException error names list. We plan to use this error name in the Secure Payment Confirmation API (see issue #1168). Since we don't need any additional attributes (i.e., we don't need a new class interface to extend DOMException), a new error name will suffice. The error name is generic so that it can be used by other APIs with similar use cases.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@nickburris
Copy link
Contributor Author

PTAL @rsolomakhin / @stephenmcgruer with your SPC API hat on (impl: https://chromium-review.googlesource.com/c/chromium/src/+/4021495)

PTAL @domenic with your webidl spec hat on, + @annevk thank you for your input on the issue, extending the error names list per your recommendation :)

Copy link

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Even if Secure Payment Confirmation is a single-implementer API, I think we should be lenient with merging values into this table, especially if they're designed to be generic in this way.

/cc @annevk @EdgarChen in case they disagree. I propose we give this a couple days in case others have thoughts then I'll merge.

@annevk
Copy link
Member

annevk commented Nov 14, 2022

Yeah I think that's okay. @nickburris should make their membership of the googlers organization public.

@domenic domenic merged commit dcde683 into whatwg:main Nov 16, 2022
stephenmcgruer pushed a commit to w3c/secure-payment-confirmation that referenced this pull request Dec 9, 2022
This PR adds spec text for a new showOptOut option in the SecurePaymentConfirmationRequest API. See the original proposal and discussion in #172. This spec change reflects the prototype currently implemented behind a flag in Chrome, which is available via origin trial and used in this test page.

The OptOutError mentioned in this change is being added to WebIDL in whatwg/webidl#1231.

Opt-out web platform test: web-platform-tests/wpt#37012

Fixes #172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants