-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More ECMAScript biblio cleanup #451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Great work! Thanks. :)
A single nit, the rest LGTM once handled.
Mind doing a quick check to see if we don't have open issues this would close?
index.bs
Outdated
Array methods to be used more easily | ||
will be the intrinsic object {{%ArrayPrototype%}} rather than | ||
{{%ObjectPrototype%}}. This allows | ||
{{Array}} methods to be used more easily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we had agreed on not linking ES standard lib objects. I think we should be consistent here. And if we change our mind, link them all up in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, you were actually more precise than that in #405 (comment). But we're not linking Array anywhere else in the spec, are we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh heh, yeah. No, we are not currently linking to Array as an interface, but we did have a link to "Array methods" which I'm trying to eliminate in favor of something more generic, like this.
Would you want me to change this to {{ECMAScript/Array}}
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. Should we strive for consistency and link Array as we do Map and Set? (Note I opened #452 to discuss this further if needed, and cement it in the spec.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it consistent with Map/Set. Also fixed #452.
Preview | Diff