Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link error breaking deploys #345

Closed
miketaylr opened this issue Mar 15, 2022 · 2 comments · Fixed by #346
Closed

link error breaking deploys #345

miketaylr opened this issue Mar 15, 2022 · 2 comments · Fixed by #346
Assignees
@noamr

Comments

@miketaylr
Copy link
Member

In https://github.com/whatwg/xhr/runs/5551269577?check_suite_focus=true,

Error running preprocessor, returned code: 2.
LINK ERROR: No 'dfn' refs found for 'terminated' with for='['fetch']'.
<a data-lt="terminated" data-link-for="fetch" data-link-type="dfn">terminate</a>
make: *** [Makefile:23: deploy] Error 22

Probably caused by whatwg/fetch@4561d5f?
@miketaylr miketaylr mentioned this issue Mar 15, 2022
Merged
@annevk
Copy link
Member

annevk commented Mar 16, 2022

Yeah, @noamr could you maybe take this?

@noamr
Copy link
Contributor

noamr commented Mar 16, 2022

Yeah, @noamr could you maybe take this?

Absolutely

@noamr noamr self-assigned this Mar 16, 2022
noamr added a commit to noamr/xhr that referenced this issue Mar 16, 2022
@noamr
Use fetch controller when terminating/aborting
f2a6af6 
Closes whatwg#345
@noamr noamr mentioned this issue Mar 16, 2022
Merged
annevk added a commit that referenced this issue Mar 17, 2022
@noamr @annevk
Use fetch controller when terminating/aborting
9d481f8 
Closes #345.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noamr noamr

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: Use fetch controller when terminating/aborting noamr/xhr
3 participants
@miketaylr @noamr @annevk