Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'type' mapping for 'entry'. #206

Merged
merged 1 commit into from
May 8, 2018
Merged

Remove 'type' mapping for 'entry'. #206

merged 1 commit into from
May 8, 2018

Conversation

tkent-google
Copy link
Contributor

@tkent-google tkent-google commented May 1, 2018 •
edited by pr-preview bot
Loading

This fixes whatwg/html#3648.

Preview | Diff

annevk
annevk reviewed May 2, 2018
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping we could avoid having this mapping here altogether if we just embrace that <form> creates File objects. What do you think of that?

@tkent-google
Copy link
Contributor Author

I was hoping we could avoid having this mapping here altogether if we just embrace that

creates File objects. What do you think of that?

I agree with it.
entry defined in XHR is a tuple of USVString name and FormDataEntryValue value, and the HTML specification should use entry.
Probably I'll work on it after this PR. I'd like to focus on removing 'type' in this PR to minimize the change size.

@annevk annevk merged commit 0b0dce1 into whatwg:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "type" from "form data set" entry
2 participants
@tkent-google @annevk