Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'type' mapping for 'entry'. #206

Merged
merged 1 commit into from May 8, 2018

Conversation

@tkent-google
Copy link
Contributor

commented May 1, 2018

This fixes whatwg/html#3648.


Preview | Diff

This fixes whatwg/html#3648.
Copy link
Member

left a comment

I was hoping we could avoid having this mapping here altogether if we just embrace that <form> creates File objects. What do you think of that?

@tkent-google

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2018

I was hoping we could avoid having this mapping here altogether if we just embrace that

creates File objects. What do you think of that?

I agree with it.
entry defined in XHR is a tuple of USVString name and FormDataEntryValue value, and the HTML specification should use entry.
Probably I'll work on it after this PR. I'd like to focus on removing 'type' in this PR to minimize the change size.

@annevk
annevk approved these changes May 7, 2018
@annevk annevk merged commit 0b0dce1 into whatwg:master May 8, 2018
2 checks passed
2 checks passed
Participation tkent-google participates on behalf of Google LLC
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.