Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a <dfn> for FormData's entry's type. #63

Closed
wants to merge 1 commit into from
Closed

Add a <dfn> for FormData's entry's type. #63

wants to merge 1 commit into from

Conversation

mikewest
Copy link
Member

I'd like to link to this from other specs.

WDYT, @annevk ?

I'd like to link to this from other specs.
@annevk
Copy link
Member

annevk commented Apr 15, 2016

How do you plan on using this?

At some point I should really tighten the integration with HTML here...

@mikewest
Copy link
Member Author

Step 9.2.1 of https://w3c.github.io/webappsec-credential-management/#passwordcredential-form-constructor (which I think I copy/pasted from HTML somewhere?).

@mikewest
Copy link
Member Author

Sorry, I didn't copy it. I'm misremembering an earlier draft where I was mildly forking https://html.spec.whatwg.org/multipage/forms.html#constructing-form-data-set.

@annevk
Copy link
Member

annevk commented Apr 15, 2016

You could just check that value is a string. That whole thing seems very hackish though and not really primitive-inspired...

@mikewest
Copy link
Member Author

shrug You know that bit better than I do. I'd be happy to have a cleaner way to turn a FormData into a URLSearchParams (or to allow urlencoded serialization of the one so that I didn't need to do the conversion in the first place). As-is, this seems like the set of materials I have to work with, so...

@annevk
Copy link
Member

annevk commented Apr 16, 2016

Agreed on shrug 😊. I'm not entirely sure what to do here given that my colleagues are less than enthused by the credentials specification. So I could put effort in it, but at the moment there doesn't seem much likelihood of success.

As for this change, it seems you could also check the type of the value, right? Or is there something I'm missing?

@mikewest
Copy link
Member Author

mikewest commented Sep 8, 2016

Abandoning this. :)

@mikewest mikewest closed this Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants