Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: added global URL type to MockMatcherUrl #647

Closed
wants to merge 3 commits into from

Conversation

flevi29
Copy link
Contributor

@flevi29 flevi29 commented Oct 29, 2022

In the docs the second entry to Argument values states that url can be any of String and URL, however the types do not support URL.

@flevi29
Copy link
Contributor Author

flevi29 commented Oct 29, 2022

It seems that karma-webpack 3.0.5 needs webpack@"^2.0.0 || ^3.0.0", but the current version sits at 4.46.0. NPM is strict with peers. There are 3 options:

  1. Use --legacy-peer-deps when installing dependencies (dirty, peer deps are enforced for a good reason in my opinion)
  2. Update karma
  3. Downgrade webpack

@flevi29
Copy link
Contributor Author

flevi29 commented Oct 29, 2022

I am not sure what to do about the last issue, tests seem to pass alright. It's a coveralls issue, token related or something similar. Can you do something about it @wheresrhys ?

@wheresrhys
Copy link
Owner

Thanks for this. I will pull this change into fetch-mock@10

@wheresrhys wheresrhys closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants