ECIP1045 + ethereum/tests #21

whilei · 2018-09-10T17:12:30Z

[] This is a "hybrid" branch, merging ECIP1045 feature branch + ethereum/tests inclusion branch. TODO: reference those PRs/+branches.

Instead of 'tests/files/'

This will be utilized by incoming state test marshaling revisions

💾 💾

solution: workaround for skipping tests by name without regexp

solution: check the proper error Some but not all blockchain tests are failing now, too, in addition to state tests. These are either because of parsing problems (like 'invalid 'x' cases, probably), or because of configuration mismatched (perhaps like the tests failing because of Difficulty and gas used...).

problem: want to skip all tests for a fork by name

solution: trim 0x prefix

solution: create dedicated ChainConfigs for use by these tests - compiles core/config/assets

This is because there is a valid block header that is assumed to exist but doesn't. This commit includes a debugging attempt to check 0x- prefix, which does not resolve the problem.

solution: add prefix and debugging lines

solution: use regex to match tests by name

solution: remove declaration :floppy_disk:

solution: refactor

…code

solution: since STATICCALL functions equivalently to CALL, use congruent behavior to CALL during gas decision log switch statement

solution: ECIP1045Block->ECIP1045BBlock

solution: add deferred chain.Stop call

This is a problem because the function will only respond to anything, eg. quitting, at 5 second intervals. solution: refactor to use alternate ticker range syntax, allowing the loop to exit immediately when bc.quit closes

solution: return any error if non nil

…loop" This reverts commit b2c2064.

Causing test timeouts. These tests are run natively, and don't need to be run thru BlockchainTests. This also refactors the test-skip matching to a not-very-pretty solution. This also _enables_ Byzantium _and_ Constantinople tests by removing them from the skip list.

solution: remove it

solution: uncomment tests

So it's less distracting from finding the actual tests.

solution: use new pointer for contract gas

solution: implement missing exported fn for ethtest testrunner

whilei · 2018-09-17T12:50:19Z

tests/state_test_util.go

+			if !ok {
+				return fmt.Errorf("key=%s fork=%s not supported", key, st.Fork)
+			}
+			_, err := test.Run(test, st, rs)


This will also return state, so if desired you can add some extra debug-y log.Printlns or even a return value to the function for handling in the cmd/ethtest package.

solution: trimspace and use only existing clean skip string

whilei added 30 commits August 14, 2018 12:44

git submodule add https://github.com/ethereum/tests tests/testdata

01be876

Specify testdata submodule as base dir for JSON tests

0f0f3a5

Instead of 'tests/files/'

Run all block_tests by walking BlockchainTests/ files - passing

2e2f452

Walk and run transactions_tests recursively

a81beb9

Walk and run vm_tests - passing

ed1ee1b

Include ETH common/math

39397d8

This will be utilized by incoming state test marshaling revisions

Walk and run state_tests - passing+failing

cb8c7d9

💾 💾

Reword test log OK -> PASS for consistent 'wc -l' output

fbb1c0d

save

0870b31

problem: BlockchainTests failing Byzantium tests

c933040

solution: workaround for skipping tests by name without regexp

Include EIP158 as skip pattern for BlockSkipTests

a57bbec

Use regexp matcher for skip tests (instead of hard ==)

771179d

problem: want to skip all tests for a fork by name

problem: invalid character 'x' during decoding

f050dea

solution: trim 0x prefix

problem: tests/BlockchainTests want dedicated chain configs

554609d

solution: create dedicated ChainConfigs for use by these tests - compiles core/config/assets

save

7f0721e

problem: tests/BlockchainTests causing panic

e63cb08

This is because there is a valid block header that is assumed to exist but doesn't. This commit includes a debugging attempt to check 0x- prefix, which does not resolve the problem.

problem: tests use 0x-prefixed hashes for validBlocks

6d42686

solution: add prefix and debugging lines

problem: tests fail for non-JSON files

e583396

solution: use regex to match tests by name

Script for running tests (for WIP use)

6235eaa

problem: btheader declared and not used

c6f1d48

solution: remove declaration :floppy_disk:

problem: json skip tests refactored

78e974a

solution: refactor

Return nil in case 2nd bc test trial passed (noop)

afad43f

Remove dead code, leave comment about test sub-run

2134181

begin work on implementing STATICCALL from scratch

4126cd8

Implement STATICCALL opcodes in vm/opcodes dictionaries

e5a31fd

Implement IsByzantium ruleset interface fn for use with STATICCALL op…

2b7e2e8

…code

Placeholder for opStaticCall as vm instruction

e8ff0a4

💾

1546640

problem: must calculate gas and size for STATICCALL

77e0db2

solution: since STATICCALL functions equivalently to CALL, use congruent behavior to CALL during gas decision log switch statement

whilei added 3 commits September 10, 2018 12:20

Merge branch 'master' into ecip1045

49bd3aa

Merge branch 'master' into ecip1045

b60d7b1

Merge branch 'master' into ecip1045-with-tests

7b656ac

whilei added active work in progress labels Sep 10, 2018

whilei added 22 commits September 10, 2018 12:40

problem: ECIP1045Block not exists

e64b381

solution: ECIP1045Block->ECIP1045BBlock

problem: never-ending runBlockchainTest

794d6bb

solution: add deferred chain.Stop call

problem@core/blockchain.go: bc.update called at 5sec interval

471ce4e

This is a problem because the function will only respond to anything, eg. quitting, at 5 second intervals. solution: refactor to use alternate ticker range syntax, allowing the loop to exit immediately when bc.quit closes

problem@tests: runBlockTest doesn't handle db write errors

f63f9fe

solution: return any error if non nil

core/multivm_processor: add panic-unreachable during vm.Fire loop

b2c2064

Revert "core/multivm_processor: add panic-unreachable during vm.Fire …

36d4623

…loop" This reverts commit b2c2064.

problem: imported and not used import regexp

6f2a861

solution: remove it

WIP: implement basic instructions test (only SHL)

8319e6c

core/vm: implement TestSHR, TestSAR

25899c6

core/vm: TestSGT, TestSLT

2fefda4

core/vm: TestByteOp

ef42ef0

Merge branch 'ecip1045' into ecip1045-with-tests

27c352b

problem@core/vm/contracts_test: tests were comment b/c git merge mishap

5ca3af7

solution: uncomment tests

core/vm: move empty interface-satisfying method to lower in file

87ab35b

So it's less distracting from finding the actual tests.

core/vm,common: refactor common big ints in contracts fns

f2009fa

core/vm: TestOpMStore

0dfa3e8

core/vm: op benchmarks

e8db755

core/vm: BenchmarkOpMstore

546f69f

problem@core/vm: Out of Gas error for precomp benches

5014643

solution: use new pointer for contract gas

Merge branch 'ecip1045' into ecip1045-with-tests

c493e0e

problem@cmd/ethtest: not implemented RunStateTestWithReader

75563e7

solution: implement missing exported fn for ethtest testrunner

whilei commented Sep 17, 2018

View reviewed changes

whilei and others added 2 commits September 17, 2018 09:00

problem@tests: empty skip string matches to skip blocktests w/ ethtest

8796fe8

solution: trimspace and use only existing clean skip string

-lm link flag for new sputnikvm

675f4d1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ECIP1045 + ethereum/tests #21

ECIP1045 + ethereum/tests #21

whilei commented Sep 10, 2018

whilei Sep 17, 2018

ECIP1045 + ethereum/tests #21

Are you sure you want to change the base?

ECIP1045 + ethereum/tests #21

Conversation

whilei commented Sep 10, 2018

whilei Sep 17, 2018

Choose a reason for hiding this comment