use_die_instead_exit

[regcostajr]

#1 (comment)

[whindsx]

Thanks for the PR. Seems reasonable and I'd like to include it.

However the die at Line 86 seems to just get skipped over (the others work):
$info = $btc->getaddressinfo("12312");
It's weird it just skips right over that and continues execution.

Did you test it and it work for you? I'm using Perl 5.20.2, I doubt it matters.

Any idea why this might now work? Some funny business with LWP::UserAgent?
https://github.com/regcostajr/Bitcoin-RPC-Client/blob/a4a851d37ab96a83d8992e398fc6a1574ebd5d14/lib/Bitcoin/RPC/Client.pm#L86

[regcostajr]

@whindsx, yes you are right, the die seems to have no behavior inside the handler, but I'm wondering if this handler is really needed since we have this error handling here too:

Bitcoin-RPC-Client/lib/Bitcoin/RPC/Client.pm

Line 115 in 365c1ad

if ($res->is_error) {

We should die after the error is confirmed right? so should be fine to die at this point and remove the handler totally, I will update the PR.

[whindsx]

We should leave the \n in the die statements, as it prevents the line number from being added to the error line. What went wrong is irrelevant to where it went wrong in Client.pm. The output should be as close as possible to what bitcoind produces IMO.

error code: -5, error message: Invalid address (getaddressinfo) at /btc/regcostajr/Bitcoin-RPC-Client/lib/Bitcoin/RPC/Client.pm line 95.

error code: -5, error message: Invalid address (getaddressinfo)

https://perldoc.perl.org/functions/die.html
If the string exception does not end in a newline, the current script line number and input line number (if any) and a newline are appended to it.