Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests to accuraterip.com are missing a user agent which identifies whipper #439

Closed
JoeLametta opened this issue Dec 30, 2019 · 0 comments
Closed

Requests to accuraterip.com are missing a user agent which identifies whipper #439

JoeLametta opened this issue Dec 30, 2019 · 0 comments
Assignees
@JoeLametta
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Priority: low Low priority Sprintable Small enough to sprint on Status: in progress Issue/pull request which is currently being worked on Stretch Optional goal for the current sprint (may not be delivered)
Milestone
1.0

Comments

@JoeLametta
Copy link
Collaborator

Don't think it's required but it would be impolite not to announce the software making the requests with its name, version and contact information.

See this too: #436 (comment).
@JoeLametta JoeLametta added Bug Generic bug: can be used together with more specific labels Accepted Accepted issue on our roadmap Priority: low Low priority labels Dec 30, 2019
JoeLametta added a commit that referenced this issue Jan 29, 2020
@JoeLametta
Add whipper useragent to AccurateRip requests
498bdd8 
Untested.

Don't think it's required but it would be impolite not to announce
the software making the requests with its name, version and
contact information.

Fixes #439.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
@JoeLametta JoeLametta self-assigned this Jan 29, 2020
@JoeLametta JoeLametta added Sprintable Small enough to sprint on Stretch Optional goal for the current sprint (may not be delivered) labels Jan 29, 2020
@JoeLametta JoeLametta added this to the 1.0 milestone Jan 29, 2020
@JoeLametta JoeLametta added the Status: in progress Issue/pull request which is currently being worked on label Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeLametta JoeLametta

Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Priority: low Low priority Sprintable Small enough to sprint on Status: in progress Issue/pull request which is currently being worked on Stretch Optional goal for the current sprint (may not be delivered)
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@JoeLametta