Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag audio tracks with ISRCs (if available) #509

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

JoeLametta
Copy link
Collaborator

Untested.

Fixes #320.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
@JoeLametta JoeLametta force-pushed the feature/issue-320-isrc-audio-tag branch from 8113080 to acf942b Compare September 19, 2020 20:14
@JoeLametta
Copy link
Collaborator Author

JoeLametta commented Sep 19, 2020

Tested with a single CD which didn't have ISRCs and cdemu (which seems to self-close if I provide a cue sheet with ISRCs) but I think this is working.
I've just added an if check not to tag the track if the ISRC value is None.

@JoeLametta JoeLametta merged commit 3c9e75c into develop Sep 23, 2020
@JoeLametta JoeLametta deleted the feature/issue-320-isrc-audio-tag branch September 23, 2020 17:56
@MerlijnWajer
Copy link
Collaborator

@JoeLametta - looks like it's causing trouble: #512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants