Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8 error in Template.php #78

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Fix PHP 8 error in Template.php #78

merged 1 commit into from
Mar 5, 2021

Conversation

martijngastkemper
Copy link
Contributor

Required parameter $closure follows optional parameter $date

fixes #76

@martijngastkemper
Fix PHP 8 error in Template.php
c0029fe 
Required parameter $closure follows optional parameter $date

fixes whitecube#76
@martijngastkemper martijngastkemper force-pushed the optional-parameter-follows-required branch from 1ebbe68 to c0029fe Compare January 20, 2021 15:02
toonvandenbos
toonvandenbos approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@toonvandenbos toonvandenbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Sorry for the delay, was kinda busy on other projects.

@toonvandenbos toonvandenbos merged commit 7c702d2 into whitecube:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toonvandenbos toonvandenbos toonvandenbos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8 error "Required parameter $closure follows optional parameter $date"
2 participants
@martijngastkemper @toonvandenbos