Support "compact CIDR": trailing zeros may be omitted from IP part. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haight6716
force-pushed
the
master
branch
3 times, most recently
from
3f5dd16
to
69df227
Compare
This is a non-standard but common shorthand when referring to CIDR networks.
|
I have no complaints if it works. Just that I have never seen that usage before during my recent 4 years of post secondary. I just hope that they will understand that the parsing for IP Address will not be equal if they enter '8' vs '8/8' as this doesn't implicitly imply /32 masking if '8' was entered as is. |
|
I think this is too obscure to be in scope for this library. I may reconsider if the use case is sufficiently motivated (with sample use of such syntax done by a major vendor). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-standard but common shorthand when referring to
CIDR networks.