Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #361

Merged
merged 2 commits into from
Aug 1, 2017
Merged

Fix warnings #361

merged 2 commits into from
Aug 1, 2017

Conversation

iliabylich
Copy link
Collaborator

  1. Fixed warnings in Parser::Source::Rewriter.
  2. Fixed warnings coming from minitest (assert nil, value -> assert_nil value, see MT 6 roadmap minitest/minitest#666)
  3. Changed CI config, it can fix an issue with installing 1.9.2 on Travis.

@whitequark
Copy link
Owner

Any idea why the JRuby builds started failing? If it's unrelated I'll merge.

@iliabylich
Copy link
Collaborator Author

@whitequark I've installed jruby locally (jruby 9.1.11.0-SNAPSHOT) and everything works fine (both rake and rake regenerate). I have no ideas what's wrong with CI.

It can be related to bumping OS version from precise to trusty, but anyway, precise is no longer supported and travis plans to start forcing trusty this September.

@whitequark whitequark merged commit 6293393 into whitequark:master Aug 1, 2017
@iliabylich iliabylich deleted the fix-warnings branch February 19, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants