Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax bundler dev dependency to allow bundler v2.0.0.pre2 #535

Closed
wants to merge 1 commit into from

Conversation

walf443
Copy link
Contributor

@walf443 walf443 commented Dec 8, 2018

ruby 2.6.0-rc1 was released.
https://www.ruby-lang.org/en/news/2018/12/06/ruby-2-6-0-rc1-released/

it seems to bundles bundler v2.0.0.pre2 https://github.com/bundler/bundler/releases/tag/v2.0.0.pre.2

I'd like to test rubocop with v2.6.0-rc1. But without this changes, it got following errors.

$ bunlde install
NOTE: Gem::Specification#has_rdoc= is deprecated with no replacement. It will be removed on or after 2018-12-01.
Gem::Specification#has_rdoc= called from /Users/yoshimin/src/github.com/whitequark/parser/parser.gemspec:15.
Fetching gem metadata from https://rubygems.org/.............
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (~> 1.15)

  Current Bundler version:
    bundler (2.0.0)
This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running `gem install bundler`?

Could not find gem 'bundler (~> 1.15)' in any of the relevant sources:
  the local ruby installation

CHANGELOG.md Outdated
@@ -5,6 +5,7 @@ Not released (2018-10-29)
-------------------------

Bugs fixed:
* relaxed bundler dependencies (Keiji, Yoshimi)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is autogenerated from commit messages, see CONTRIBUTING.md.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I see.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walf443 Could you revert this change please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iliabylich I'm sorry to reply slowly. I fixed it.

@walf443
Copy link
Contributor Author

walf443 commented Dec 8, 2018

Note: running on ruby 2.6.0-rc1 is failing by this issue ruby/racc#98

@whitequark
Copy link
Owner

It looks like newer bundler obsoletes every Ruby version prior to 2.3. You need to take these out of the Travis build matrix as well.

@walf443
Copy link
Contributor Author

walf443 commented May 19, 2019

It may be #543 was cherry-picked this commit and it merged. so this issue should be closed. thanks.

@walf443 walf443 closed this May 19, 2019
@walf443 walf443 deleted the relax_bundler_deps branch May 19, 2019 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants