-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax bundler dev dependency to allow bundler v2.0.0.pre2 #535
Conversation
420e046
to
5f876c5
Compare
CHANGELOG.md
Outdated
@@ -5,6 +5,7 @@ Not released (2018-10-29) | |||
------------------------- | |||
|
|||
Bugs fixed: | |||
* relaxed bundler dependencies (Keiji, Yoshimi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog is autogenerated from commit messages, see CONTRIBUTING.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@walf443 Could you revert this change please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iliabylich I'm sorry to reply slowly. I fixed it.
5f876c5
to
433df4d
Compare
Note: running on ruby 2.6.0-rc1 is failing by this issue ruby/racc#98 |
433df4d
to
1830646
Compare
1830646
to
8565dba
Compare
It looks like newer bundler obsoletes every Ruby version prior to 2.3. You need to take these out of the Travis build matrix as well. |
It may be #543 was cherry-picked this commit and it merged. so this issue should be closed. thanks. |
ruby 2.6.0-rc1 was released.
https://www.ruby-lang.org/en/news/2018/12/06/ruby-2-6-0-rc1-released/
it seems to bundles bundler v2.0.0.pre2 https://github.com/bundler/bundler/releases/tag/v2.0.0.pre.2
I'd like to test rubocop with v2.6.0-rc1. But without this changes, it got following errors.