+ ruby27.y: removed opt_block_args_tail: tOROP rule. #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule was the only one that didn't unset current_arg.
Thus, it allows `def foo(var: bar { || var }) var end`.
This commit tracks upstream commits ruby/ruby@7c22898 and ruby/ruby@ed90ec3.
palkan
added a commit
to ruby-next/parser
that referenced
this pull request
Nov 20, 2019
* bilych/pattern-matching: + ruby27.y: added pattern matching + lexer.rl: parse embedded ivars/cvars starting with digit as str (whitequark#639) * README.md: documented compatibility issue with EOF chars after… (whitequark#637) + lexer.rl: warn on `...` at EOL. (whitequark#636) + ruby27.y: removed opt_block_args_tail: tOROP rule. (whitequark#635) + ruby27.y: reverted method reference operator (added in whitequark#634) + ruby27.y: treat numparams as locals outside numblock. (whitequark#633) * ruby27.y: refactor logic around 'circular argument reference'(whitequark#628)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule was the only one that didn't unset current_arg.
Thus,
def foo(var: bar { || var }) var endis now a valid syntax.This commit tracks upstream commits ruby/ruby@7c22898 and ruby/ruby@ed90ec3.
Closes #629 (that allows this syntax by fixing this rule)
Closes #630 (that removes the rule and changes lexer to emit a different sequence of terminals and use a different rule that allows new syntax).
It's easier to apply them both.