Add support for multiple report formats in one run #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunosilva800
approved these changes
Feb 19, 2019
|
Mentioning #202 |
|
Great work!! 💯 |
|
Small nit. I'd add the following to the |
|
I agree. @katafrakt Can you please add those lines to gitignore, and rebase with master? Builds should be working now. |
added 2 commits
February 26, 2019 09:57
When you pass --format option to rubycritic, it should be possible to use that option more than once and have reports in different formats created without having to run whole analysis twice.
katafrakt
force-pushed
the
multiple-report-formats
branch
from
31e0208
to
9c0b347
Compare
|
Wonderful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you pass
--formatoption to RubyCritic, it should be possible to use that option more than once and have reports in different formats created without having to run whole analysis twice.My use case is to run in in CI, then extract some data from JSON report and send it to Slack, but also publish the HTML report, so people can examine it in a friendly way.
I'm not sure if tests I wrote are enough, but it was all that came to mind.