BUGFIX: use Minitest rather than deprecated MiniTest constant #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minitest 5.19.0 only loads the legacy compatibility layer if you have the MT_COMPAT environment variable set -- minitest/minitest@a2c6c18. This causes use of the MiniTest module name to fail, as well as the bundled older mocha. Fix our code to use the correct Minitest name, and update to a fixed mocha.
3 tasks
|
@nunosilva800, @etagwerker can you take a look please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minitest 5.19.0 only loads the legacy compatibility layer if you have the MT_COMPAT environment variable set -- minitest/minitest@a2c6c18. This causes use of the MiniTest module name to fail, as well as the bundled older mocha. Fix our code to use the correct Minitest name, and update to a fixed mocha.
Check list: