WIP: Address test warning by declaring cucumber_opts using %w[] instead of… #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://my.diffend.io/gems/minitest/5.18.1/5.19.0#d2h-230603 Looking to fix this in a way that's compatible across releases. Failing that, I'll lock the minitest dependency to the earlier version so we have the minimal change here. |
faisal
changed the title
faisal
force-pushed
the
clean_cucumber_opts_array_warning
branch
2 times, most recently
from
696ba65
to
4193774
Compare
faisal
changed the title
|
#464 fixes the issue that caused test breaks here. If we land that fix then we should undo the minitest version restriction in this PR before merging. |
- Declare cucumber_opts with a %w[] instead of a string, as the latter produces a warning while testing, and may be unsafe.
faisal
force-pushed
the
clean_cucumber_opts_array_warning
branch
from
4193774
to
fa7a478
Compare
nunosilva800
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list:
This is a minor change in the Rakefile, clearing a test warning (see 465) by declaring
cucumber_optsusing%w[]syntax instead of a raw string.