Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the file loading/parsing smarter #101

Open
whitlockjc opened this issue Oct 10, 2016 · 1 comment
Open

Make the file loading/parsing smarter #101

whitlockjc opened this issue Oct 10, 2016 · 1 comment

Comments

@whitlockjc
Copy link
Owner

whitlockjc commented Oct 10, 2016

Right now, we use the YAML parser to parse all inputs by default. Since valid JSON is valid YAML, a single parser works great and we don't have to do any content negotiation or resort to brittle filename checking. The problem is that invalid JSON can be valid YAML and the result is json-refs happily parsing invalid JSON without reporting the error. We should attempt to make it so that invalid JSON will fail to parse.

Originally reported here: apigee-127/swagger-tools#435

whitlockjc added a commit that referenced this issue Apr 20, 2017
The resolver was rewritten to fix numerous bugs and performance issues.
The reason for this is over the years, bug fixes and features have been
added on top of json-refs and its resolver logic has become crufty.  The
new rewrite is clean, does not reinvent the wheel and fixes many bugs.

Fixes: #80, #87, #88, #89, #97, #101, #103
whitlockjc added a commit that referenced this issue Apr 20, 2017
The resolver was rewritten to fix numerous bugs and performance issues.
The reason for this is over the years, bug fixes and features have been
added on top of json-refs and its resolver logic has become crufty.  The
new rewrite is clean, does not reinvent the wheel and fixes many bugs.

Fixes: #80, #87, #88, #89, #97, #100, #101, #103
@whitlockjc whitlockjc reopened this Apr 22, 2017
@whitlockjc
Copy link
Owner Author

This was closed by mistake, reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant