Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch tsl_triggered to True #803

Merged
merged 1 commit into from Jun 1, 2023
Merged

Switch tsl_triggered to True #803

merged 1 commit into from Jun 1, 2023

Conversation

LucienC
Copy link
Contributor

@LucienC LucienC commented May 26, 2023

Description

Because of this, the is_sell_trigger was never triggered with fixed trailingstoploss and trigger
Maybe Fixes #801

Type of change

  • Bug fix

alexfromvl
alexfromvl reviewed May 28, 2023
View reviewed changes
Copy link

@alexfromvl alexfromvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works and matches a similar call on the lines before

@whittlem whittlem changed the base branch from main to beta June 1, 2023 19:11
@whittlem
Copy link
Owner

whittlem commented Jun 1, 2023

Thanks for the update. PR's get raised against "beta" branch first. I have done this for you.

@whittlem whittlem merged commit 5e696d1 into whittlem:beta Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfromvl alexfromvl alexfromvl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preventloss does not work with declining market
3 participants
@LucienC @whittlem @alexfromvl