Shrink select-data-modal so that it fits on smaller screens #623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
My previous testing was done on larger monitors, but it seems like my 13-inch laptop screen has issues with
max-height: 600px
on theselect-data-modal
. If the list grows too long, the Submit button can be pushed off the screen, despite having set amax-height
.Approach
Shrank to
max-height: 400px
so that it will fit smaller laptop screens.Ideally, this would be a percentage or use a value like
50vh
or similar to assign a fraction (e.g. 50%) of the viewport height, but this would take more experimentation with a larger selection of monitors that I don't have at my disposal.How to Test
select-data-modal
)select-data-modal