Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Catteville hierarchy and Petit-Caux name #17

Closed
wants to merge 1 commit into from

Conversation

Joxit
Copy link

@Joxit Joxit commented Oct 30, 2019

Hello,

I found some missing hierarchy for two localities names Catteville.
And for 404426875, Berneval-Le-Grand is the name of one of the old localities that was merged to form Petit-Caux. So the real name for this localadmin is Petit-Caux

@Joxit
Copy link
Author

Joxit commented Dec 26, 2019

Hi there, I updated this PR : run exportify on updated files + rebase.

@stepps00
Copy link
Contributor

Hey @Joxit - Looks like this PR slipped through the cracks, so thanks for updating.

I suspect there is a bit more work to do here, as we need to keep the "old" name for this place (and update any name: properties. I'll also need to PIP this PR to update any descendant records. I'll take a look over the next few days and hopefully merge this work - thanks again!

@stepps00 stepps00 closed this Dec 26, 2019
@stepps00 stepps00 reopened this Dec 26, 2019
@Joxit
Copy link
Author

Joxit commented Dec 27, 2019

Hi @stepps00 😄, The old name Berneval-le-Grand is still present as locality:101900099 but the shape for the old locality is incorrect, I know we can't use OSM, but it should looks like this

@Joxit
Copy link
Author

Joxit commented Jun 3, 2020

Sync with master. Do you have some news for this PR ?

@stepps00
Copy link
Contributor

stepps00 commented Jun 9, 2020

Hi @Joxit - thank you! Because this PR involves name changes, we'd need to create a new record and supersede the existing record into it. Each record also needs to be run through the exportify tools to update the wof:lastmodified date and validate the changes.

I think I can checkout your branch and make the adjustments. Let me poke around this week and push a new commit so this can be merged... stay tuned and thanks again!

@Joxit Joxit closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants