Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create label.md #35

Merged
merged 3 commits into from
Sep 6, 2017
Merged

Create label.md #35

merged 3 commits into from
Sep 6, 2017

Conversation

Copy link
Member

@thisisaaronland thisisaaronland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.


The "preferred" disambiguation label for a place (exclusive of hierarchy), in practice a single element list. Either append the feature's placetype or append the parent's name in parenthesis.

_Example: kor_x_preferred_dissambiguation_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example: kor_x_preferred_disambiguation

@stepps00
Copy link
Member

stepps00 commented Sep 6, 2017

Other than dissambiguation -> disambiguation, LGTM

@stepps00
Copy link
Member

stepps00 commented Sep 6, 2017

LGTM

@nvkelso nvkelso merged commit 154352f into master Sep 6, 2017
@nvkelso nvkelso deleted the nvkelso/add-label.md branch September 6, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants