Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Format of Results Template #3

Open
whs2k opened this issue Mar 28, 2018 · 7 comments
Open

Modify Format of Results Template #3

whs2k opened this issue Mar 28, 2018 · 7 comments

Comments

@whs2k
Copy link
Owner

whs2k commented Mar 28, 2018

  • Center the Bill Summary Text under the Bill Title and reduce the text size and weight.

  • Limit the number of Sponsors to 10 (as to not clog the output)

  • Bold or heavier weight the first sponsor name (as he or she is the primary sponsor on a bill)

image

@mixmastamyk
Copy link
Collaborator

Did you really mean centered or indented? I made it indented previously, and have now added bold, smaller text, sponsor limit, and bottom margin. Take a look.

@whs2k
Copy link
Owner Author

whs2k commented Mar 29, 2018

For the sponsors, it looks like the output of the function isn't actually a list but a string: str(list(output)) Regex up to "]," ?

Also, can we give the indented text a lighter weight still?

image

@mixmastamyk
Copy link
Collaborator

Doh on the sponsors. By lighter do you mean the color or the weight of the text? The color is easy to change, the weight may not be depending on the font, I'll have to investigate tomorrow.

@whs2k
Copy link
Owner Author

whs2k commented Mar 29, 2018

Ok, ignore the weight, a lighter color is fine. If possible, a slightly smaller font than 'sponsors' would be ideal as well to show more contrast (nice to have, not must have).

@mixmastamyk
Copy link
Collaborator

Another issue. If the list of sponsors is actually a text string instead of a proper list, it will be hard to reliably make the first one bold. Guess we could chop on the bracket characters, are they guaranteed to be there?

mixmastamyk added a commit that referenced this issue Mar 29, 2018
@mixmastamyk
Copy link
Collaborator

Hi, take a look at my updates when ya have a chance.

@whs2k
Copy link
Owner Author

whs2k commented Apr 5, 2018

Looks good so far and understood about the Bold Issue. It looks like the issue is the dataframe of arrays that is being saved in csv format can't be maintained (CSV can't handle an array of strings in a cell). The Bracket characters will always be there though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants