Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .otc support, fix invalid .ttc/.otc handling and update readme.md to match the new features. #9

Merged
merged 5 commits into from Mar 24, 2021

Conversation

Zopolis4
Copy link
Contributor

@Zopolis4 Zopolis4 commented Mar 18, 2021

This PR adds support for unpacking .otc files. It also causes the script to print an error message and then continue when the script encounters a broken .ttc/.otc file. Previously, when the script encountered an invalid .ttc/.otc file it would refuse to parse any of the files in the directory. It also updates the readme.md to include the new features added in the PR.

Causes the script to print an error message and then continue when the script encounters a broken .ttc file.
Allows the script to unpack .otc files (resulting fonts are .ttf)
@Zopolis4 Zopolis4 changed the title Fix invalid .ttc handling Add .otc support and fix invalid .ttc/.otc handling Mar 18, 2021
The script no longer changes .otf files extracted from .otc to .ttf
@Zopolis4 Zopolis4 changed the title Add .otc support and fix invalid .ttc/.otc handling Add .otc support, fix invalid .ttc/.otc handling and update readme.md to match the new features. Mar 18, 2021
Copy link
Owner

@whtsky whtsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. The changes look good overall.

font_rename.py Show resolved Hide resolved
@whtsky whtsky merged commit 625de21 into whtsky:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants