fix: allow ignoring the footnotes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the footnotes are seen as broken links. this PR adds a new option to ignore footnotes links and thus enable retro-compatibility with the previous API. ▫️ Creates new option to the command line ▫️ Sets option default value to false ▫️ Implements behavior ▫️ Test: Adds new lines to docs1/test.md ▫️ Test: Extends with 3 assertions ▫️ Test: Increments dead links from 5 to 6
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 97.88% 97.89% +0.01%
==========================================
Files 2 2
Lines 189 190 +1
==========================================
+ Hits 185 186 +1
Misses 4 4
Continue to review full report at Codecov.
|
whxaxes
approved these changes
Jun 28, 2020
|
Thank you for your PR |
|
1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the footnotes are seen as broken links. this PR adds a new option to ignore footnotes links and thus enable retro-compatibility with the previous API.
▫️ Creates new option to the command line
▫️ Sets option default value to false
▫️ Implements behavior
▫️ Test: Adds new lines to docs1/test.md
▫️ Test: Extends with 3 assertions
▫️ Test: Increments dead links from 5 to 6