Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception Error #312

Closed
mcpalmer1980 opened this issue Nov 17, 2019 · 10 comments
Closed

Exception Error #312

mcpalmer1980 opened this issue Nov 17, 2019 · 10 comments
Labels
bug Something isn't working Linux Related to Linux

Comments

@mcpalmer1980
Copy link

I have a few features I wanted to try implimenting but am getting errors with the AppImage I generate on Linux Mint 18.3. It runs fine the first time, but a get an exception error after that unless I delete the $home$/.config/video-hub-app folder.

Note that I've never built a node.js app but doubt I could have done anything wrong. I installed the latest npm, node.js, and Electron and built with the following command.

npm run build:prod && electron-builder build --linux

Error Dialog

Uncaught Exception:
TypeError: Cannot set property 'selectedIndex' of undefined
    at EventEmitter.<anonymous> (/tmp/.mount_Video xCmHR5/resources/app.asar/main.js:815:44)
    at EventEmitter.emit (events.js:200:13)
    at WebContents.<anonymous> (/tmp/.mount_Video xCmHR5/resources/electron.asar/browser/api/web-contents.js:335:21)
    at WebContents.emit (events.js:200:13)

Build Log

VideoHub npm run build:prod && electron-builder build --linux

> video-hub-app-2@2.0.0 build:prod /home/mcpalmer/VideoHub
> npm run build -- -c production


> video-hub-app-2@2.0.0 build /home/mcpalmer/VideoHub
> npm run postinstall:electron && npm run electron:serve-tsc && ng build "-c" "production"


> video-hub-app-2@2.0.0 postinstall:electron /home/mcpalmer/VideoHub
> node postinstall


> video-hub-app-2@2.0.0 electron:serve-tsc /home/mcpalmer/VideoHub
> tsc -p tsconfig-serve.json

                                                                            
chunk {0} runtime.ee0aae13fb762b150814.js (runtime) 1.41 kB [entry] [rendered]
chunk {1} main.4261b3c89ed18d381138.js (main) 1.31 MB [initial] [rendered]
chunk {2} polyfills.77b6099bf795cc68d244.js (polyfills) 46 kB [initial] [rendered]
chunk {3} polyfills-es5.f6e4f7f783ff74a1064c.js (polyfills-es5) 69.8 kB [initial] [rendered]
chunk {4} styles.f42fbb34746ba625daba.css (styles) 52 bytes [initial] [rendered]
Date: 2019-11-17T01:06:05.519Z - Hash: 28a693057b0929157781 - Time: 22598ms
  • electron-builder  version=21.2.0 os=4.10.0-38-generic
  • loaded configuration  file=/home/mcpalmer/VideoHub/electron-builder.json
  • writing effective config  file=release/builder-effective-config.yaml
  • packaging       platform=linux arch=x64 electron=6.0.6 appOutDir=release/linux-unpacked
  • building        target=AppImage arch=x64 file=release/Video Hub App 2-2.0.0.AppImage
@whyboris
Copy link
Owner

Thank you for the bug report 🙇

The only place I see selectedIndex in the app is in the main.ts -- and all the mentions of it were added recently with a PR: #299 that adds Mac Touch Bar Support

I have not built the app since the addition of this feature -- perhaps we need to only call the methods that touch it when the app is running on a Mac (see codeRunningOnMac variable). Perhaps the app doesn't build/run on Mac / Windows either 🤷‍♂ 😅

I suspect your app will build fine if you check out an earlier commit before this PR was merged, or if you temporarily gut the Touch Bar feature :trollface:

@whyboris whyboris added the bug Something isn't working label Nov 17, 2019
@whyboris whyboris mentioned this issue Nov 17, 2019
Closed
@cal2195 cal2195 mentioned this issue Nov 18, 2019
Merged
@cal2195
Copy link
Collaborator

cal2195 commented Nov 18, 2019

Found the two places requiring a condition - I think we need a touchBarEnabled bool, as not all macs have touchbars! 👍

See my comments on #61

@bigesses
Copy link
Contributor

bigesses commented Dec 2, 2019

Hey, can I take this? Will fix it (:

bigesses added a commit to bigesses/Video-Hub-App that referenced this issue Dec 2, 2019
@bigesses
Exception Error whyboris#312 - fixed
35dfb07
whyboris added a commit that referenced this issue Dec 2, 2019
@whyboris
Merge pull request #319 from bigesses/master
ac9de11 
Exception Error #312 - fixed
@whyboris
Copy link
Owner

whyboris commented Dec 2, 2019

I think this can be closed now that #319 has been merged. @mcpalmer1980 -- if you happen to check with the latest master please let us know 🤝

@mcpalmer1980
Copy link
Author

mcpalmer1980 commented Dec 3, 2019 via email

@whyboris
Copy link
Owner

whyboris commented Dec 3, 2019

@mcpalmer1980 sorry it still fails -- I've not tested the app.
After the release lands, I start merging PRs that update the functionality, and until the next release the app may be broken.

If you'd like the app to build, I'm confident the 2.0.0 release will work, just check out the master at this point in the commit history: https://github.com/whyboris/Video-Hub-App/releases/tag/v2.0.0

I'll likely find time in the coming weeks (or at least during my winter break) to fix the Linux build again so I can release 2.1.0

The build instructions should be as simple as npm run electron:linux ... I'm unsure why it's not working for you. I built my .appimage in Ubuntu running inside a virtual machine on Mac 🤷‍♂

@mcpalmer1980
Copy link
Author

mcpalmer1980 commented Dec 3, 2019 via email

@whyboris
Copy link
Owner

whyboris commented Dec 3, 2019

I think node has to be at least version 10 (try 10.16.0 or higher; 12 works too 👍 )

@whyboris
Copy link
Owner

@mcpalmer1980 -- I'm thinking about closing this issue. Please comment if you think it should stay open for some reason 👍

@whyboris whyboris added the Linux Related to Linux label Feb 27, 2020
@whyboris
Copy link
Owner

Closing as I suspect this has been solved. Please feel free to comment or create a new issue as needed 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Linux Related to Linux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cal2195 @whyboris @mcpalmer1980 @bigesses