New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting options - sort by size / duration / etc #108
Conversation
Please I'm now opting to pre- (and re-) computing the resolution string (and resolution sorting bucket) every time we open a vha file. This simplifies the resolution pipe somewhat, but also provides an important new feature: In the future we could refactor the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm loving the idea of temporary variables generated at launch, but I don't think we should save them to the vha file - have I missed something, or what is your thoughts? 😄
I realized after submitting the PR and before falling asleep I should just remove the Fixed with 87b01d6 🎉 |
Thank you :) - resolved with latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🎉
I'll resolve the conflicts now and merge it 👍 |
Sort by:
vha
file.TODO: In a future PR, simplify the silly
shuffleTheViewNow
hack and confirm that the old shuffle button and keyboard shortcuts work.