Add fps #635
Add fps #635
Conversation
interfaces/final-object.interface.ts
Outdated
| @@ -39,6 +39,7 @@ export interface ImageElement { | |||
| stars: StarRating; // star rating 0 = n/a, otherwise 1, 2, 3 | |||
| timesPlayed: number; // number of times the file has been launched by VHA | |||
| width: number; // width of the video (px) | |||
| frameRate: number; // base frame rate of the video in fps | |||
There was a problem hiding this comment.
I don't have a strong preference, but perhaps fps is better - as it's shorter and is already a well-known acronym 🤔
node/main-support.ts
Outdated
| * Generate frame rate display formatted as XXfps | ||
| * @param frameRate | ||
| */ | ||
| function getFrameRateDisplay(frameRate: number): string { |
There was a problem hiding this comment.
I think this is better done in the template (.html file) 👍
The reason some other values are stored in the ImageElement object rather than live-computed is because their computation is much more computationally heavy, while this one is just appending text 👍
| @@ -34,6 +34,8 @@ | |||
|
|
|||
| | {{ video.fileSizeDisplay }} | |||
|
|
|||
| | {{ video.frameRateDisplay }} | |||
There was a problem hiding this comment.
Here is where we can add the "fps" text 🤝
|
Thank you @jleckron -- updated code looks great! I'll test it before merging this weekend 🤝 |
|
I tested -- works beautifully. I'll update the translations for other languages and add the button to the "Sorting options" list ✅ Excellent work - thank you very much 🙇 🤝 🎖️ |
|
I made a few quick changes -- making the FPS search toggleable in the settings 🤝 |
* Added fps display * fps display works on test cases * Added sortby fps in sidebar * Fixed formatting (removed whitespace) * Switched fps ordering to better match with other ordering patterns * Changed template to fps, removed unnecessary functions, shortened variable names
Hi Boris,
I added functionality to see the real frame rate for each video in detailed mode 😉
I also added functionality to use the sidebar to sort by fps. In doing so, I added a couple new key-value pairs in
en.json. According toi18n/README.md, hopefully it is simple to expand my changes for all other supported languages.Please let me know of any changes you would like to see.
Thank you for the support!
Issue #623