Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added button to sort auto tags #774

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Added button to sort auto tags #774

merged 1 commit into from
Oct 31, 2022

Conversation

gabriel-kazimir
Copy link

Button is in "Tags" section in "View setting". I also added a czech translation for it.

@whyboris
Copy link
Owner

Thank you for the code contribution 🙇
This should close #713
I'll try to find time to test it locally this weekend and merge it in 👍

@whyboris whyboris mentioned this pull request Oct 17, 2022
Closed
whyboris
whyboris reviewed Oct 17, 2022
View reviewed changes
Copy link
Owner

@whyboris whyboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great -- looking forward to testing it locally 👍

@gabriel-kazimir
Copy link
Author

Hello @whyboris :) did you find some time to test it locally? I can see, that it is still open, so i don't know if I should improve something or you haven't found the time for it yet. :)

@whyboris
Copy link
Owner

Sorry to leave you hanging. This weekend I ended up trying to finish up this project:
https://github.com/whyboris/utilitarianism.net
But I'll definitely close out this PR before October is over 🙇 -- I'll see if I have time today 😊

@gabriel-kazimir
Copy link
Author

I see, it´s fine, nevermind 😃

whyboris
whyboris approved these changes Oct 31, 2022
View reviewed changes
Copy link
Owner

@whyboris whyboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - works beautifully 😍

Thank you for the careful work 🤝

whyboris
whyboris reviewed Oct 31, 2022
View reviewed changes
src/app/components/meta/meta.component.html
: showAutoFileTags
: showAutoFolderTags
: tagViewUpdateHack)
| autoTagSortPipe"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than duplicating the block and adding the pipe here, a simpler solution would be to have the pipe accept a boolean for whether to filter the contents 😉

I tested locally and it works great, so I'll make this small change after merging 🤝

@whyboris whyboris merged commit 1067a0c into whyboris:main Oct 31, 2022
@whyboris
Copy link
Owner

Thank you again @gabriel-kazimir for this code contribution 🙇

I made a small adjustment after your PR: deef6fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyboris whyboris whyboris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabriel-kazimir @whyboris